Skip to content

simplify the describeConfiguration and describeRelease#456

Merged
ktalebian merged 1 commit intov4-betafrom
simplify-configured-plugins
May 6, 2021
Merged

simplify the describeConfiguration and describeRelease#456
ktalebian merged 1 commit intov4-betafrom
simplify-configured-plugins

Conversation

@ktalebian
Copy link
Copy Markdown
Contributor

  • Take advantage of the new API to simplify calls for describing configuration/release

@ktalebian ktalebian requested review from agupt and ahcai May 6, 2021 02:13
@codecov
Copy link
Copy Markdown

codecov bot commented May 6, 2021

Codecov Report

Merging #456 (859b762) into v4-beta (bff57d9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v4-beta     #456      +/-   ##
===========================================
+ Coverage    85.38%   85.39%   +0.02%     
===========================================
  Files          147      147              
  Lines         3570     3560      -10     
  Branches       588      587       -1     
===========================================
- Hits          3048     3040       -8     
+ Misses         420      419       -1     
+ Partials       102      101       -1     
Impacted Files Coverage Δ
...lugins-api-client/src/clients/configuredPlugins.ts 100.00% <ø> (ø)
...ugins-api-toolkit/src/flexPluginsAPIToolkitBase.ts 100.00% <100.00%> (ø)
...s-api-toolkit/src/scripts/describeConfiguration.ts 100.00% <100.00%> (+8.00%) ⬆️
...plugins-api-toolkit/src/scripts/describeRelease.ts 100.00% <100.00%> (ø)
...kages/flex-plugins-api-toolkit/src/scripts/diff.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff57d9...859b762. Read the comment docs.

Copy link
Copy Markdown
Contributor

@ahcai ahcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@ktalebian ktalebian merged commit 5dadf11 into v4-beta May 6, 2021
@ktalebian ktalebian deleted the simplify-configured-plugins branch May 6, 2021 19:36
pragya-arora added a commit that referenced this pull request Mar 18, 2026
…-rmvq)

Add npm override to force serialize-javascript to 7.0.3, resolving
Dependabot alert #456. The transitive dependency was locked to 4.x/5.x
by webpack 4's terser-webpack-plugin and could not be auto-updated.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants