Conversation
Contributor
ktalebian
commented
Apr 19, 2019
ktalebian
commented
- Adds linter
- Apply all linter and fix errors/warnings
package.json
Outdated
| { | ||
| "scripts": { | ||
| "lint": "tslint --project tsconfig.json", | ||
| "lint:fix": "tslint --project tsconfig.json", |
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "useTabs": false, | |||
| "tabWidth": 2, | |||
Contributor
There was a problem hiding this comment.
any particular reason for changing the tabWidth in the entire project?
Contributor
Author
There was a problem hiding this comment.
@krishnakalluri and I are going to work on a tslint/eslint config and publish it to Twilio repo; Twilio mostly uses 4 spaces for spacing.
theryankennedy
approved these changes
Apr 22, 2019
andreasonny83
pushed a commit
to andreasonny83/flex-plugin-builder
that referenced
this pull request
May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.