Instructions in Contributing, Docker has issues

[craiglondon]

I was following the instructions for contributing.

https://github.com/twilio/twilio-php/blob/main/CONTRIBUTING.md

When I ran
make docker-dev-build VERSION=7.4-rc

It does not complete successfully

$ make docker-dev-build VERSION=7.4-rc
docker stop twilio_php7.4-rc
Error response from daemon: No such container: twilio_php7.4-rc
make: [docker-dev-build] Error 1 (ignored)
docker rm twilio_php7.4-rc
Error response from daemon: No such container: twilio_php7.4-rc
make: [docker-dev-build] Error 1 (ignored)
docker image build --tag="twilio/php7.4-rc" --build-arg version=7.4-rc -f ./Dockerfile-dev .
[+] Building 1.1s (7/9)                                                                                                                                                                      docker:desktop-linux
 => [internal] load build definition from Dockerfile-dev                                                                                                                                                     0.0s
 => => transferring dockerfile: 419B                                                                                                                                                                         0.0s
 => WARN: InvalidDefaultArgInFrom: Default value for ARG php:$version results in empty or invalid base image name (line 2)                                                                                   0.0s
 => [internal] load metadata for docker.io/library/php:7.4-rc                                                                                                                                                0.4s
 => [internal] load .dockerignore                                                                                                                                                                            0.0s
 => => transferring context: 2B                                                                                                                                                                              0.0s
 => [1/6] FROM docker.io/library/php:7.4-rc@sha256:0ba47246481a994c2ee4b854bdf6103e8923caeb57e90fca989d5dee9ff6b548                                                                                          0.0s
 => CACHED [2/6] RUN curl --silent --show-error https://getcomposer.org/installer | php                                                                                                                      0.0s
 => CACHED [3/6] RUN mv composer.phar /usr/local/bin/composer                                                                                                                                                0.0s
 => ERROR [4/6] RUN  apt-get update -y &&      apt-get upgrade -y &&      apt-get dist-upgrade -y &&      apt-get -y autoremove &&      apt-get clean                                                        0.6s
------                                                                                                                                                                                                            
 > [4/6] RUN  apt-get update -y &&      apt-get upgrade -y &&      apt-get dist-upgrade -y &&      apt-get -y autoremove &&      apt-get clean:                                                                   
0.394 Ign:1 http://security.debian.org/debian-security buster/updates InRelease                                                                                                                                   
0.402 Ign:2 http://deb.debian.org/debian buster InRelease                                                                                                                                                         
0.419 Err:3 http://security.debian.org/debian-security buster/updates Release                                                                                                                                     
0.419   404  Not Found [IP: 151.101.2.132 80]                                                                                                                                                                     
0.427 Ign:4 http://deb.debian.org/debian buster-updates InRelease
0.452 Err:5 http://deb.debian.org/debian buster Release
0.452   404  Not Found [IP: 146.75.126.132 80]
0.475 Err:6 http://deb.debian.org/debian buster-updates Release
0.475   404  Not Found [IP: 146.75.126.132 80]
0.488 Reading package lists...
0.509 E: The repository 'http://security.debian.org/debian-security buster/updates Release' does not have a Release file.
0.509 E: The repository 'http://deb.debian.org/debian buster Release' does not have a Release file.
0.509 E: The repository 'http://deb.debian.org/debian buster-updates Release' does not have a Release file.
------

 1 warning found (use docker --debug to expand):
 - InvalidDefaultArgInFrom: Default value for ARG php:$version results in empty or invalid base image name (line 2)
Dockerfile-dev:7
--------------------
   6 |     
   7 | >>> RUN  apt-get update -y && \
   8 | >>>      apt-get upgrade -y && \
   9 | >>>      apt-get dist-upgrade -y && \
  10 | >>>      apt-get -y autoremove && \
  11 | >>>      apt-get clean
  12 |     
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c apt-get update -y &&      apt-get upgrade -y &&      apt-get dist-upgrade -y &&      apt-get -y autoremove &&      apt-get clean" did not complete successfully: exit code: 100
make: *** [docker-dev-build] Error 1

[manisha1997]

Hello!
7.4-rc is not a valid dockerfile tag.
Can you try using a valid dockerfile tag.
You can pick from https://hub.docker.com/r/twilio/twilio-php/tags

[craiglondon]

https://hub.docker.com/layers/twilio/twilio-php/7.16.2

$ make docker-dev-build VERSION=7.16.2
docker stop twilio_php7.16.2
Error response from daemon: No such container: twilio_php7.16.2
make: [docker-dev-build] Error 1 (ignored)
docker rm twilio_php7.16.2
Error response from daemon: No such container: twilio_php7.16.2
make: [docker-dev-build] Error 1 (ignored)
docker image build --tag="twilio/php7.16.2" --build-arg version=7.16.2 -f ./Dockerfile-dev .
[+] Building 0.6s (2/2) FINISHED                                                                                                                                                             docker:desktop-linux
 => [internal] load build definition from Dockerfile-dev                                                                                                                                                     0.0s
 => => transferring dockerfile: 419B                                                                                                                                                                         0.0s
 => WARN: InvalidDefaultArgInFrom: Default value for ARG php:$version results in empty or invalid base image name (line 2)                                                                                   0.0s
 => ERROR [internal] load metadata for docker.io/library/php:7.16.2                                                                                                                                          0.5s
------
 > [internal] load metadata for docker.io/library/php:7.16.2:
------

 1 warning found (use docker --debug to expand):
 - InvalidDefaultArgInFrom: Default value for ARG php:$version results in empty or invalid base image name (line 2)
Dockerfile-dev:2
--------------------
   1 |     ARG version
   2 | >>> FROM php:$version
   3 |     
   4 |     RUN curl --silent --show-error https://getcomposer.org/installer | php
--------------------
ERROR: failed to build: failed to solve: php:7.16.2: failed to resolve source metadata for docker.io/library/php:7.16.2: docker.io/library/php:7.16.2: not found
make: *** [docker-dev-build] Error 1

[manisha1997]

apologies!
The tag needs to be picked up from https://hub.docker.com/_/php