test: ittest build #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twinkle-kadia
force-pushed
the
java-workflows-ittests
branch
from
5e4510e to
2f4766c
Compare
athakor
reviewed
Sep 22, 2020
|
|
||
| @Test | ||
| public void getWorkflowTest() { | ||
| WorkflowName name2 = WorkflowName.of("[PROJECT]", "[LOCATION]", "[WORKFLOW]"); |
There was a problem hiding this comment.
Use actual value of PROJECT, LOCATION and WORKFLOW
| .build(); | ||
| mockWorkflows.addResponse(expectedResponse); | ||
|
|
||
| WorkflowName name = WorkflowName.of("[PROJECT]", "[LOCATION]", "[WORKFLOW]"); |
athakor
reviewed
Sep 22, 2020
athakor
reviewed
Sep 22, 2020
| public void testListWorkflows() { | ||
| ListWorkflowsRequest request = ListWorkflowsRequest.newBuilder().setParent(PARENT).build(); | ||
| for (Workflow actualWorkflow : client.listWorkflows(request).iterateAll()) { | ||
| assertEquals(WORKFLOW_NAME, actualWorkflow.getName()); |
There was a problem hiding this comment.
nit : this checks will failed in case of system already has workflow
better to put check here with workflowname like:
for (Workflow actualWorkflow : client.listWorkflows(request).iterateAll()) {
if(WORKFLOW_NAME.equals(actualWorkflow.getName()){
assertEquals(WORKFLOW_NAME, actualWorkflow.getName());
assertEquals(expectedWorkflow, actualWorkflow);
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️