Support pyproject.toml#91
Merged
Merged
Conversation
twm
force-pushed
the
90-pyproject.toml
branch
2 times, most recently
from
3be2c80 to
bbf48d0
Compare
This line appears to be nonsense: if the string is bytes, it won't have a decode method on any Python version we support.
It turns out that, in practice, the
Disabling this isn't helping get coverage.
This package provides the .pth hack to start coverage in sub-processes. By adding it to the build requirements of the example packages we may be able to get coverage within Pip's isolated build environment. 🤞
This is already included in file form, so there's no reason to copy the text of the file into the package metadata too.
- Move build/install into the test methods to reduce coupling with tox.ini - Add the missing COVERAGE_PROCESS_START environment variable - Move -p (parallel) to the config file - When combining, pull coverage from the example directories because the package build process uses them as a working directory
The examples don't need the coverage-p hack because the tests don't isolate the build.
glyph
approved these changes
Jul 7, 2024
Member
glyph
left a comment
glyph
left a comment
There was a problem hiding this comment.
I love it, this is a huge feature upgrade. Thanks for doing this!
- Include _build_meta.py so that python -m build works. - Include all the test files in the sdist. Fixes #80.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
setuptools.finalize_distribution_optionsentry point so that Incremental can be configured withpyproject.tomlalone. This is patterned off of the interface setuptools_scm documents: the user creates a[tool.incremental]section inpyproject.tomlThe actual implementation is quite different from the distutils one. The
finalize_distribution_optionshook always seems to be passed an emptyDistributionobject which is unable to list the files in the package. I settled on extracting the project name frompyproject.tomland reusing the logic from theincremental.updatemodule to locate_version.py. As a side effect I reworked that logic to avoid a Twisted dependency forFilePath.Also:
__version__and the package metadata matchpyproject.tomlinstead ofsetup.cfgFixes #90. Fixes #88. Fixes #80.