This repository was archived by the owner on Sep 18, 2021. It is now read-only.
Fix-up comments on the SMPP error code constants#116
Merged
Conversation
It looks like these were extracted from Table 5-2 of the SMPP Protocol Specification v3.4 using some sort of script / automation, and that extraction got messed up from the `STATUS_INVCMDID` constant onwards, such that thereafter the constants' comments were placed _after_ the constant, not before. This change simply moves the relevant constants to their correct location, _before_ their relevant constants, consistent with the class' other constants. The diff is a bit messy, which can't be helped, but the constants themselves (names and values) are not changed. For interest, the broken layout existed in the very first commit of the `SmppConstants.java` file (e6965ae) which was an "initial export of svn repo for public release".
jjlauer
added a commit
that referenced
this pull request
Nov 24, 2015
Fix-up comments on the SMPP error code constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like these were extracted from Table 5-2 of the SMPP Protocol Specification v3.4 using some sort of script / automation, and that extraction got messed up from the
STATUS_INVCMDIDconstant onwards, such that thereafter the constants' comments were placed after theconstant, not before.
This change simply moves the relevant constants to their correct location, before their relevant constants, consistent with the class' other constants. The diff is a bit messy, which can't be helped, but
the constants themselves (names and values) are not changed.
For interest, the broken layout existed in the very first commit of the
SmppConstants.javafile (e6965ae) which was an "initial export of svn repo for public release".To show that the constants were not touched, here's a diff of the change ignoring comment:
Those lines only changed because their code comments had been moved from the end of the line to the preceding line to be consistent with all the others.
Cheers.