ScaldingILoop should enable one to pass in in/out#1475
Merged
ianoc merged 4 commits intotwitter:developfrom Jan 16, 2016
Merged
ScaldingILoop should enable one to pass in in/out#1475ianoc merged 4 commits intotwitter:developfrom
ianoc merged 4 commits intotwitter:developfrom
Conversation
ianoc
added a commit
that referenced
this pull request
Jan 16, 2016
ScaldingILoop should enable one to pass in in/out
Contributor
Author
|
Thanks @ianoc. Will update Zeppelin after the next Scalding release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to fork the ScaldingILoop to get it to work with Zeppelin because it didn't provide me a way to pass thru the in/out that it needs. See:
https://github.com/apache/incubator-zeppelin/blob/master/scalding/src/main/scala/org/apache/zeppelin/scalding/ScaldingILoop.scala and apache/zeppelin#561.
I want to add that into Scalding proper so I can kill that fork. Once we release the next version of Scalding, I can create a PR to kill that code from Zeppelin. The Scalding REPL tests pass, and I already have a branch that works at:
https://github.com/sriramkrishnan/incubator-zeppelin/tree/scalding_cleanup