Skip to content

Update TypeDescriptor to explain that Option[String] is not supported #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isnotinvain merged 2 commits into from
Jan 23, 2016
Merged

Update TypeDescriptor to explain that Option[String] is not supported #1480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ca0994
Update TypeDescriptor to explain that Option[String] is not supported
isnotinvain Jan 22, 2016
a9941a8
Use triple quotes in message
isnotinvain Jan 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scalding-core/src/main/scala/com/twitter/scalding/TypeDescriptor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import scala.language.experimental.{ macros => sMacros }
* Note in the com.twitter.scalding.macros package there are macros to
* generate this for case classes, which may be very convenient.
*/
@implicitNotFound("This class is used to bind together a Fields instance to an instance of type T. There is a implicit macro that generates a TypeDescriptor[T] for any type T where T is Boolean, String, Short, Int, Long, FLoat, or Double, or an option of these, or a tuple or case class of a supported type. (Nested tuples and case classes are allowed.) If your type T is not one of these, then you must write your own TypeDescriptor.")
@implicitNotFound("""This class is used to bind together a Fields instance to an instance of type T. There is a implicit macro that generates a TypeDescriptor[T] for any type T where T is Boolean, String, Short, Int, Long, FLoat, or Double, or an option of these (with the exception of Option[String]), or a tuple or case class of a supported type. (Nested tuples and case classes are allowed.) Note: Option[String] specifically is not allowed as Some("") and None are indistinguishable. If your type T is not one of these, then you must write your own TypeDescriptor.""")
trait TypeDescriptor[T] extends java.io.Serializable {
def setter: TupleSetter[T]
def converter: TupleConverter[T]
Expand Down