Remove dependency on parquet-cascading#1488
Merged
ianoc merged 5 commits intotwitter:developfrom Feb 2, 2016
Merged
Conversation
Merge from twitter/scalding
Contributor
There was a problem hiding this comment.
why don't we need this exclude?
Contributor
Author
There was a problem hiding this comment.
Added back the exclude. There was an unused pig import in the original code which we don't need.
Contributor
|
@rubanm sounds good to me. |
Contributor
Author
|
This passes Twitter internal e2e tests. |
Contributor
|
👍 basically this is becoming a scalding mono-repo... |
Contributor
Author
|
Hah, with monobuild first this time around. |
ianoc
added a commit
that referenced
this pull request
Feb 2, 2016
Remove dependency on parquet-cascading
rubanm
pushed a commit
that referenced
this pull request
Feb 9, 2016
Remove dependency on parquet-cascading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops our dependency on parquet-cascading for easier cascading upgrades in the future (decoupled from apache's parquet release process).
As a follow-up to this change, I will copy over @cchepelov's cascading3 changes from apache/parquet-java#284 and file an issue on parquet-mr to possibly remove their version of this code (presumably, no one outside of scalding consumes this).
I copied over the java code instead of translating to scala so that
But let me know if anyone feels strongly about creating a scala version of these schemes instead.
cc @ianoc @isnotinvain @johnynek @julienledem