Fix building of statically linked binaries + MSVC workflow#225
Draft
kratz00 wants to merge 1 commit intotwogood:mainfrom
Draft
Fix building of statically linked binaries + MSVC workflow#225kratz00 wants to merge 1 commit intotwogood:mainfrom
kratz00 wants to merge 1 commit intotwogood:mainfrom
Conversation
Contributor
Author
|
Looks like Apple does not support statically linked binaries: https://developer.apple.com/library/archive/qa/qa1118/_index.html |
a677a10 to
189bf36
Compare
Owner
|
If there are too many ifs and buts maybe just remove BUILD_STATIC? |
cb9b3b9 to
239bf41
Compare
Contributor
Author
|
Where is the fun in that? I like a challenge and I am learning a lot of new things too. |
80550b6 to
6fc3d72
Compare
Contributor
Author
|
Everything is building successfully and without warnings (as far as I could see in the logs).
I will continue after the holidays - Happy Easter holidays. |
1314b0b to
69db2c9
Compare
Signed-off-by: Steffen Pankratz <kratz00@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.