feat: implements logs subscribe / unsubscribe websocket endpoint #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
MicaiahReid
requested changes
Jul 24, 2025
| err: err.clone(), | ||
| logs: logs.clone(), | ||
| }; | ||
| let _ = tx.send((self.get_latest_absolute_slot(), message)); |
Member
There was a problem hiding this comment.
Maybe a simple solution for my above question about removing from the logs_subscriptions vec is if this tx.send fails, we consider the rx disconnected and remove?
Would be easy to implement, but could potentially yield some hard to track "what happened to my subscription" bugs ¯_(ツ)_/¯
MicaiahReid
approved these changes
Jul 24, 2025
Member
MicaiahReid
left a comment
MicaiahReid
left a comment
There was a problem hiding this comment.
Thanks for making those issues and fixes! looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.