refactor(tui): enhance airdrop messages on startup #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support and updating return values
MicaiahReid
approved these changes
Aug 27, 2025
MicaiahReid
requested changes
Aug 27, 2025
Co-authored-by: Micaiah Reid <micaiahreid@gmail.com>
MicaiahReid
approved these changes
Aug 27, 2025
lgalabru
approved these changes
Aug 27, 2025
Member
lgalabru
left a comment
lgalabru
left a comment
There was a problem hiding this comment.
Looking good, thanks @BretasArthur1!
…loaded status in return values
MicaiahReid
requested changes
Aug 27, 2025
crates/cli/src/cli/mod.rs
Outdated
| } | ||
| false => { | ||
| errors.push(format!( | ||
| "No keypair found at provided path {}; skipping airdrops;", |
Member
There was a problem hiding this comment.
If the user provides 3 keypairs and 2 of them are invalid, this will log:
No keypair found at provided path {}; skipping airdrops;
No keypair found at provided path {}; skipping airdrops;
Genesis airdrop for {} successfulIt's weird we're saying "skipping" when we're not necessarily skipping
…ariables and improving event logging
MicaiahReid
approved these changes
Aug 28, 2025
MicaiahReid
added a commit
that referenced
this pull request
Sep 1, 2025
Co-authored-by: Micaiah Reid <micaiahreid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.