Skip to content

Conversation

@sonicfromnewyoke
Copy link
Collaborator

Problem

ci command cargo clippy --all-targets reports a lot of warnings

this is an initial step to more strict linting of the project, related to #352

Summary of Changes

  • apply suggestions where this is pretty safe
  • add #[allow(clippy::await_holding_lock)], #[allow(clippy::too_many_arguments)], and #[allow(clippy::large_enum_variant)] to places that require extensive refactoring

@lgalabru
Copy link
Member

lgalabru commented Oct 7, 2025

Thanks @sonicfromnewyoke!
iirc @Aursen added a step cargo +nightly fmt --all to the CI, should we also add cargo clippy --all-targets? Stable? Nightly?

@Aursen
Copy link
Contributor

Aursen commented Oct 7, 2025

I used nightly for the imports

@sonicfromnewyoke
Copy link
Collaborator Author

Thanks @sonicfromnewyoke! iirc @Aursen added a step cargo +nightly fmt --all to the CI, should we also add cargo clippy --all-targets? Stable? Nightly?

i believe --all-targets is useful, because I have already added a couple of dependency issues to that project, that were fixed by you afterward, due to shallow checks

@lgalabru lgalabru merged commit e7da774 into txtx:main Oct 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants