Skip to content

chore(cli): add don't create simnet logfile for --log-level none option #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MicaiahReid merged 1 commit into from
Oct 9, 2025
Merged

chore(cli): add don't create simnet logfile for --log-level none option #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions crates/cli/src/cli/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ pub struct StartSimnet {
/// Disable instruction profiling (eg. surfpool start --disable-instruction-profiling)
#[clap(long = "disable-instruction-profiling", action=ArgAction::SetTrue)]
pub disable_instruction_profiling: bool,
/// The log level to use for simnet logs. Options are "trace", "debug", "info", "warn", "error". (eg. surfpool start --log-level debug)
/// The log level to use for simnet logs. Options are "trace", "debug", "info", "warn", "error", or "none". (eg. surfpool start --log-level debug)
#[arg(long = "log-level", short = 'l', default_value = "info")]
pub log_level: String,
/// The directory to put simnet logs. (eg. surfpool start --log-path ./logs)
Expand Down Expand Up @@ -516,6 +516,7 @@ fn handle_command(opts: Opts, ctx: &Context) -> Result<(), String> {
cmd.disable_instruction_profiling = true;
cmd.no_studio = true;
cmd.no_tui = true;
cmd.log_level = "none".to_string();
}

if cmd.daemon {
Expand All @@ -532,7 +533,9 @@ fn handle_command(opts: Opts, ctx: &Context) -> Result<(), String> {
}
}

setup_logger(&cmd.log_dir, None, "simnet", &cmd.log_level, cmd.no_tui)?;
if cmd.log_level.to_ascii_lowercase() != "none" {
setup_logger(&cmd.log_dir, None, "simnet", &cmd.log_level, cmd.no_tui)?;
}

if cmd.daemon {
#[cfg(not(target_os = "windows"))]
Expand Down