Skip to content

Conversation

@0xsouravm
Copy link
Contributor

@0xsouravm 0xsouravm commented Nov 15, 2025

Changes:

  • Added list_plugins(meta) RPC method definition
  • Extended PluginManagerCommand enum with ListPlugins variant
  • Updated plugin_uuid_map: HashMap<Uuid, usize> into `plugin_map: HashMap<Uuid, (usize, String)>to store plugin names along with UUID for efficient listing
  • Removed rpc_addr method from the trait

Reference: #330

Copy link
Member

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I was reviewing this PR, I realized the rpc_addr method is quite a silly one 😂

You need to know the network's rpc address in order to fetch it's rpc address via rpc... so why do we need the method? hahaha

Would you be able to remove the changes from that method, and that method from the AdminRpc trait completely?

@0xsouravm
Copy link
Contributor Author

As I was reviewing this PR, I realized the rpc_addr method is quite a silly one 😂

You need to know the network's rpc address in order to fetch it's rpc address via rpc... so why do we need the method? hahaha

Would you be able to remove the changes from that method, and that method from the AdminRpc trait completely?

When put that way, it does sound funny. 😹 . Sure I will remove all instances of the method and the structure field I added to tests and elsewhere!

@0xsouravm
Copy link
Contributor Author

@MicaiahReid I have added the changes you requested. Please take a look!

@0xsouravm 0xsouravm changed the title feat: add list_plugins and rpc_addr admin RPCs feat: add list_plugins admin RPC and remove rpc_addr admin RPC method from trait Nov 20, 2025
Copy link
Member

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @0xsouravm!!

@MicaiahReid MicaiahReid self-requested a review November 20, 2025 20:29
@MicaiahReid MicaiahReid merged commit b528cdf into txtx:main Nov 20, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants