Skip to content

Conversation

@bytehash69
Copy link
Contributor

Fix non-zero exit code on runbook execution failure

  • Check boolean return from process_runbook_execution_output()
  • Return Err in unsupervised mode when execution fails
  • Exit with code 1 in supervised mode when execution fails

Fixes #400

Copy link
Member

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great thanks @bytehash69!

@bytehash69
Copy link
Contributor Author

Hey @MicaiahReid , please review this pr!

Copy link
Member

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MicaiahReid
Copy link
Member

Looks like you'll need to fix the formatting! You can run cargo +nightly fmt --all -- --check to see what needs to be fixed

@bytehash69
Copy link
Contributor Author

Hey @MicaiahReid , i've fixed the formatting!

@lgalabru lgalabru merged commit d932f1c into txtx:main Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return non-zero exit code on failed runbooks

3 participants