feat(cli): add --runbook-input flag to surfpool start #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
gm gm @MicaiahReid ser, can you please take a look ? |
MicaiahReid
requested changes
Nov 26, 2025
Member
MicaiahReid
left a comment
MicaiahReid
left a comment
There was a problem hiding this comment.
This is awesome! Just tested, it's working great. Just one small change request.
crates/cli/src/cli/simnet/mod.rs
Outdated
| } | ||
| } | ||
|
|
||
| let input_location = cmd.runbook_input.clone(); |
Member
There was a problem hiding this comment.
This is a weird name, can we rename to runbook_input?
Signed-off-by: Shivendra Mishra <shivendramishra.sm93@gmail.com>
shibu0x
force-pushed
the
feat/runbook-input-start
branch
from
32a32c1 to
81b2473
Compare
MicaiahReid
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for passing runbook input files during
surfpool start,mirroring the existing
--inputfunctionality insurfpool run.This allows overriding
txtx.ymlinputs for the automaticallyexecuted deployment runbooks when starting the simnet.
Closes #281