-
Notifications
You must be signed in to change notification settings - Fork 107
feat: Add transaction ingestion benchmarks using Criterion #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oh wow, awesome @TanmayDhobale, it looks awesome! |
just fixed ;) |
MicaiahReid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool! I've never done bench testing with rust before, this was very informative for me!
One bigger refactor request: rather than adding new dependencies to core, can we add a new bench crate to the root of the project (in the crates folder)? This crate can pull the benchmark crates as well as surfpool-core as a dependency.
yea thanks !now we created the new crates/bench crate in the root crates folder and it pulls |
…mark and simplify CI workflow command
lgalabru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thanks @TanmayDhobale !
cc @lgalabru #441