Skip to content

Conversation

@tanmay4l
Copy link
Contributor

@tanmay4l tanmay4l commented Dec 7, 2025

@tanmay4l tanmay4l marked this pull request as draft December 7, 2025 07:04
@lgalabru
Copy link
Member

lgalabru commented Dec 7, 2025

Oh wow, awesome @TanmayDhobale, it looks awesome!
I aborted the CI as it's been running for 1h40 now 😂
Do you know what could be wrong with it?
Thanks for this contribution, it's going to be super useful for some incoming features, so we'll merge it ASAP.

@tanmay4l tanmay4l marked this pull request as ready for review December 7, 2025 14:57
@tanmay4l
Copy link
Contributor Author

tanmay4l commented Dec 7, 2025

Oh wow, awesome @TanmayDhobale, it looks awesome! I aborted the CI as it's been running for 1h40 now 😂 Do you know what could be wrong with it? Thanks for this contribution, it's going to be super useful for some incoming features, so we'll merge it ASAP.

just fixed ;)

Copy link
Member

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! I've never done bench testing with rust before, this was very informative for me!

One bigger refactor request: rather than adding new dependencies to core, can we add a new bench crate to the root of the project (in the crates folder)? This crate can pull the benchmark crates as well as surfpool-core as a dependency.

@tanmay4l
Copy link
Contributor Author

tanmay4l commented Dec 8, 2025

This is really cool! I've never done bench testing with rust before, this was very informative for me!

One bigger refactor request: rather than adding new dependencies to core, can we add a new bench crate to the root of the project (in the crates folder)? This crate can pull the benchmark crates as well as surfpool-core as a dependency.

yea thanks !now we created the new crates/bench crate in the root crates folder and it pulls
in surfpool-core as a dependency

@tanmay4l tanmay4l marked this pull request as draft December 8, 2025 19:34
@tanmay4l tanmay4l marked this pull request as ready for review December 8, 2025 20:31
@tanmay4l tanmay4l requested a review from MicaiahReid December 10, 2025 15:36
Copy link
Member

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thanks @TanmayDhobale !

@lgalabru lgalabru merged commit e16fe95 into txtx:main Dec 12, 2025
4 checks passed
@tanmay4l tanmay4l deleted the bench branch December 24, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants