Skip to content

feat: Add skip_signature_verification option to SimnetConfig #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgalabru merged 4 commits into from
Dec 27, 2025
Merged

feat: Add skip_signature_verification option to SimnetConfig #456

lgalabru merged 4 commits into from
Dec 27, 2025

Conversation

@tanmay4l
Copy link
Contributor

@tanmay4l tanmay4l commented Dec 24, 2025 •
edited
Loading

@tanmay4l tanmay4l marked this pull request as ready for review December 24, 2025 19:24
lgalabru
lgalabru reviewed Dec 26, 2025
View reviewed changes
Copy link
Member

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking sharp, thanks @tanmay4l!
The code looks correct to me, do you think you could add some unit tests?

@lgalabru lgalabru mentioned this pull request Dec 26, 2025
Closed
@tanmay4l
Copy link
Contributor Author

tanmay4l commented Dec 26, 2025

Looking sharp, thanks @tanmay4l! The code looks correct to me, do you think you could add some unit tests?

oh ive wrriten test alrdy but didnt push bcs thought not needed but pushing now

@tanmay4l tanmay4l requested a review from lgalabru December 26, 2025 08:36
lgalabru
lgalabru approved these changes Dec 27, 2025
View reviewed changes
Copy link
Member

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great thank you for jumping on this issue @tanmay4l 💪

@lgalabru lgalabru merged commit 0226fcc into txtx:main Dec 27, 2025
4 checks passed
@tanmay4l tanmay4l deleted the Feat branch December 28, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgalabru lgalabru lgalabru approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tanmay4l @lgalabru