Issue #10 -- unix lib.rs passes non zero terminated strings to dlopen#12
Open
tyleo wants to merge 1 commit intotyleo:masterfrom
Open
Issue #10 -- unix lib.rs passes non zero terminated strings to dlopen#12tyleo wants to merge 1 commit intotyleo:masterfrom
tyleo wants to merge 1 commit intotyleo:masterfrom
Conversation
…lopen Converting to CString type before passing as a C pointer to dlopen added the \0 termination and obviates one of the casts. Tests would fail if the same rigor was applied to dlsym because optional \0 termination is used as a feature (see example calls of find_func() in lib_impl/lib.rs).
|
Looks like the tests are failing because gradle is not working on Travis CI's Mac OS? I didn't actually use the gradle build because I don't know how it works, just ran cargo build for the examplelib and copied it to .build. |
Owner
Author
|
Yeah, I looked at it yesterday. I think that gradlew just needs to be updated but didn’t test out the update before signing off.
… On Sep 30, 2018, at 11:49, Maximiato ***@***.***> wrote:
Looks like the tests are failing because gradle is not working on Travis CI's Mac OS? I didn't actually use the gradle build because I don't know how it works, just ran cargo build for the examplelib and copied it to .build.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting to CString type before passing as a C pointer to dlopen added the \0 termination and obviates one of the casts. Tests would fail if the same rigor was applied to dlsym because optional \0 termination is used as a feature (see example calls of find_func() in lib_impl/lib.rs).