Skip to content

Initial code#1

Merged
argumatronic merged 1 commit intomasterfrom
initial-code
Feb 25, 2018
Merged

Initial code#1
argumatronic merged 1 commit intomasterfrom
initial-code

Conversation

@chris-martin
Copy link
Member

@chris-martin chris-martin commented Feb 21, 2018

Hi, so this library is really just a thin wrapper around Bryan O'Sullivan's base16-bytestring library, with the aim to be more convenient when you're using the Text type, and to have documentation that's aimed more directly at this particular use case.

I have another function called lazilyDecodeHex written, but it doesn't work due to a bug in the underlying library, so I haven't included it here yet.

What do you think?

@argumatronic
Copy link
Member

argumatronic commented Feb 22, 2018

OK, I was going to edit the README but I have to fork the branch or something. So you said we'll just merge it, so I was going to merge it and I don't think I can?

So the README should make mention of why we need this, both in a general sense and specifically our use case, I think, and perhaps a comment in that line of code we discussed where you unpack that ByteString for purposes of Showing it in the REPL? Perhaps we should also comment on why we didn't use one of the available options out there.

@argumatronic argumatronic merged commit 009fc67 into master Feb 25, 2018
@chris-martin chris-martin deleted the initial-code branch February 25, 2018 20:06
@chris-martin
Copy link
Member Author

Punted readme improvements and lazy-decode into issues #2 and #3 respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants