Merged
Conversation
Member
|
OK, I was going to edit the README but I have to fork the branch or something. So you said we'll just merge it, so I was going to merge it and I don't think I can? So the README should make mention of why we need this, both in a general sense and specifically our use case, I think, and perhaps a comment in that line of code we discussed where you unpack that |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, so this library is really just a thin wrapper around Bryan O'Sullivan's base16-bytestring library, with the aim to be more convenient when you're using the
Texttype, and to have documentation that's aimed more directly at this particular use case.I have another function called
lazilyDecodeHexwritten, but it doesn't work due to a bug in the underlying library, so I haven't included it here yet.What do you think?