[v2] Use Babel 7 transforms rather than tsc for transpilation#334
Merged
[v2] Use Babel 7 transforms rather than tsc for transpilation#334
Conversation
5 tasks
51088a4 to
1c2c215
Compare
Member
|
Confirmed this works in our ~60kloc TS app. No issues, some workarounds needed as expected. |
Member
Author
|
I should add that I've gotten build + tests passing on a couple of open source projects as well
|
1c2c215 to
0019e11
Compare
Member
Author
|
Since this has gotten an initial pass of testing, I'm going to merge this branch into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR constitutes the first chunk of work toward #333. It replaces our use of
tscwith@babel/plugin-transform-typescriptfor transpiling TypeScript files in the host.Some notes:
ember-cliand converted the main addon module to TypeScriptincremental-typescript-compilercode is still around for now; it will be cleaned up in the future once we have a good handle on typecheckingts:precompilecommand now only emits.d.tsfiles, since the.tsones are consumed normally by Babelember-cli#masterin order to actually test it, but since we're now just using a Babel plugin, the risk of breakage is much lower