Conversation
chriskrycho
approved these changes
Oct 24, 2018
3a45d7e to
d32dde7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reintroduces typechecking into the
v2rewrite ofember-cli-typescript. It spawns a worker process that's responsible for checking the project and emits type errors to stdout.If
noEmitOnErroris set and there are type errors, it also fails builds/rebuilds in ember-cli'spostBuild()hook, and when runningember serveand similar, it serves a type error page.Note that we're no longer plugging in any kind of customized watcher to the compiler. This means we'll be strongly recommending
ember-cli@>=3.5withember-cli-typescript@2, as 3.5 moves the Broccoli working directory out of the project, eliminating a ton of fs events thattschas historically struggled with on many systems.I ran through the diff here with @chriskrycho earlier today; we're aiming to cut an initial prerelease tomorrow.