Skip to content

[v2] Reintroduce typechecking#347

Merged
dfreeman merged 4 commits intov2from
typechecking
Oct 25, 2018
Merged

[v2] Reintroduce typechecking#347
dfreeman merged 4 commits intov2from
typechecking

Conversation

@dfreeman
Copy link
Member

This change reintroduces typechecking into the v2 rewrite of ember-cli-typescript. It spawns a worker process that's responsible for checking the project and emits type errors to stdout.

If noEmitOnError is set and there are type errors, it also fails builds/rebuilds in ember-cli's postBuild() hook, and when running ember serve and similar, it serves a type error page.

Note that we're no longer plugging in any kind of customized watcher to the compiler. This means we'll be strongly recommending ember-cli@>=3.5 with ember-cli-typescript@2, as 3.5 moves the Broccoli working directory out of the project, eliminating a ton of fs events that tsc has historically struggled with on many systems.

I ran through the diff here with @chriskrycho earlier today; we're aiming to cut an initial prerelease tomorrow.

typecheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants