Skip to content

Update recommended mypy & CI to 1.1.1, update MultiValueDict #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
intgr merged 3 commits into from
Mar 10, 2023
Merged

Update recommended mypy & CI to 1.1.1, update MultiValueDict #1391

intgr merged 3 commits into from
Mar 10, 2023

Conversation

@intgr
Copy link
Collaborator

@intgr intgr commented Mar 10, 2023 •
edited
Loading

Error was:

django-stubs/utils/datastructures.pyi:68: error: Signature of "setdefault" incompatible with supertype "MutableMapping"
django-stubs/utils/datastructures.pyi:68: note:      Superclass:
django-stubs/utils/datastructures.pyi:68: note:          @overload
django-stubs/utils/datastructures.pyi:68: note:          def setdefault(self, _K, None = ..., /) -> Optional[_V]
django-stubs/utils/datastructures.pyi:68: note:          @overload
django-stubs/utils/datastructures.pyi:68: note:          def setdefault(self, _K, _V, /) -> _V
django-stubs/utils/datastructures.pyi:68: note:      Subclass:
django-stubs/utils/datastructures.pyi:68: note:          def setdefault(self, key: _K, default: _V = ...) -> _V
Found 1 error in 1 file (checked 675 source files)

Related issues

Closes #1387

@intgr intgr mentioned this pull request Mar 10, 2023
Closed
@intgr intgr added the help wanted Extra attention is needed label Mar 10, 2023
@intgr intgr mentioned this pull request Mar 10, 2023
Merged
adamchainz
adamchainz approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@intgr intgr merged commit 0aa7bf1 into master Mar 10, 2023
@intgr intgr deleted the update-mypy branch March 10, 2023 17:59
@intgr
Copy link
Collaborator Author

intgr commented Mar 10, 2023

Thanks!

@intgr intgr restored the update-mypy branch March 11, 2023 12:31
@intgr intgr deleted the update-mypy branch March 16, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamchainz adamchainz adamchainz approved these changes

Assignees

No one assigned

Labels

help wanted Extra attention is needed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@intgr @adamchainz