Skip to content

Conversation

@bdrazhzhov
Copy link
Member

I've added ability to use TS node module (if it's available) with fallback to internal module.
Now 1.4.x is stable branch and it does not include typescript.js file and I decided to use tsc.js as source file.

@jakoss
Copy link

jakoss commented Jun 29, 2015

Awsome! It's pretty sad that this repository is kinda abandoned. Solution you've prepared is great

@tkawachi
Copy link
Member

@bdrazhzhov Could you help maintaining this repository? I'm willing to add you as a contributor.

@jakoss
Copy link

jakoss commented Jun 29, 2015

@tkawachi He has github account only for this fork, so i'm not sure if he's active. Could you accept this pull reqest? It would solve a lot of problems in https://github.com/typescript-ruby/typescript-rails repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't throw an exception even if the directory doesn't exist.

@bdrazhzhov
Copy link
Member Author

@tkawachi I'm new in RoR and I would like to help with maintaining this repository.

@tkawachi
Copy link
Member

Thank you @bdrazhzhov. I've invited you to this organisation. I hope you commit/merge pull requests. Currently none of organisation owners are active.

BTW, I think it's not good to always detect npm installed tsc. It's better to be able to configure by library users.

@bdrazhzhov
Copy link
Member Author

Oh... Thank you! Will implement it.

Added ability to use external Typescript compiler
bdrazhzhov added a commit that referenced this pull request Jul 6, 2015
Using local TS node module
@bdrazhzhov bdrazhzhov merged commit 8323203 into typescript-ruby:master Jul 6, 2015
@bdrazhzhov
Copy link
Member Author

@tkawachi, could you provide me permission to push the gem to rubygems.org? What do you need to know from me for permission providing?

@tkawachi
Copy link
Member

tkawachi commented Jul 7, 2015

@bdrazhzhov According to the FAQ, your email address which is registered to rubygems.org is needed.

@bdrazhzhov
Copy link
Member Author

I used templar8@gmail.com for rubygems.org.
I would like to publish typescript-node-ruby and typescript-rails gems too. Could you provide me permissions for these gem publishing to rubygems.org?

@tkawachi
Copy link
Member

tkawachi commented Jul 7, 2015

I've added you to typescript-src and typescript-node as an owner.
I'm not an owner of typescript-rails, could you add @bdrazhzhov as an owner, @gfx @klaustopher ?

@gfx
Copy link
Member

gfx commented Jul 7, 2015

@bdrazhzhov Added you to owners of typescript-rails. Thanks to maintain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants