Conversation
Having some issues with the use_vignette function, so don't think this is a proper vignette... probably just a markdown.
|
Hi @DrLundRasmussen . Looks great and well done. Could I get you to run an "R CMD check" on your branch before I merge? I'll explain this in our meeting if that doesn't make sense. Thanks! |
|
Hi @tystan , thanks! |
|
Hmmm not sure what's going on @DrLundRasmussen. From a quick search it might be a permissions thing but we'll get to the bottom of it |
|
Hi @tystan! How would you like to proceed...? |
tystan
left a comment
There was a problem hiding this comment.
Thanks for all these changes @DrLundRasmussen! I have also looked at the vignette - it looks good and thank you for setting it all up. I just need to work out how to accept the majority of these changes and I'll chat to you about the others
|
No problem at all @tystan. You've done aaaall the work! Hope it can be of some use but please feel free not to accept any of my changes. |
Major changes: added vignette and editing the readme file.
Minor changes: unit testing of create_seq_bin_part() function.