FEAT Moonshot Attack Module: Insert Punctuation Attack#1
Open
FEAT Moonshot Attack Module: Insert Punctuation Attack#1
Conversation
added 4 commits
October 17, 2024 10:42
…r if it returns false in convert_asyn
ghost
suggested changes
Oct 18, 2024
ghost
left a comment
There was a problem hiding this comment.
Well done on the logic of the code and the testing!
For low effort improvements, proofread for some minor typos. Also, comments should be capitalised, similar to other files, and cut down on some unnecessary comments as this kind of bloats the code.
added 3 commits
October 18, 2024 17:43
u7702792
reviewed
Oct 20, 2024
Collaborator
u7702792
left a comment
There was a problem hiding this comment.
I think the code is good, you can add the relevant docs later
Test Results936 tests +22 934 ✅ +23 2m 44s ⏱️ -1s Results for commit 38bd280. ± Comparison against base commit d8c32d1. This pull request removes 2 and adds 24 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
insert_punctuation_attack_converter.pyandInsertPunctuationGeneratorclass.test_insert_punctuation_attack_converter.pyto test correctness of the generator.