Skip to content

FEAT Moonshot Attack Module: Insert Punctuation Attack#1

Open
u7780339 wants to merge 12 commits intomainfrom
feat/insert_punctuation_attack_generator
Open

FEAT Moonshot Attack Module: Insert Punctuation Attack#1
u7780339 wants to merge 12 commits intomainfrom
feat/insert_punctuation_attack_generator

Conversation

@u7780339
Copy link
Copy Markdown
Owner

Description

@u7780339 u7780339 marked this pull request as ready for review October 16, 2024 10:49
@u7780339 u7780339 requested a review from a user October 18, 2024 05:40
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on the logic of the code and the testing!

For low effort improvements, proofread for some minor typos. Also, comments should be capitalised, similar to other files, and cut down on some unnecessary comments as this kind of bloats the code.

Comment thread pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated
Comment thread pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated
Comment thread pyrit/prompt_converter/insert_punctuation_attack_converter.py
Comment thread tests/converter/test_insert_punctuation_converter.py
Comment thread tests/converter/test_insert_punctuation_converter.py Outdated
Comment thread pyrit/prompt_converter/insert_punctuation_attack_converter.py Outdated
Comment thread pyrit/prompt_converter/insert_punctuation_attack_converter.py
Copy link
Copy Markdown
Collaborator

@u7702792 u7702792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code is good, you can add the relevant docs later

Comment thread pyrit/prompt_converter/insert_punctuation_attack_converter.py
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 10, 2024

Test Results

936 tests  +22   934 ✅ +23   2m 44s ⏱️ -1s
  1 suites ± 0     2 💤  -  1 
  1 files   ± 0     0 ❌ ± 0 

Results for commit 38bd280. ± Comparison against base commit d8c32d1.

This pull request removes 2 and adds 24 tests. Note that renamed tests count towards both.
tests.test_azure_auth ‑ test_get_token_provider_from_default_azure_credential
tests.test_hf_model_downloads ‑ test_download_specific_files_with_aria2
tests.converter.test_insert_punctuation_converter ‑ test_default_swap[Aha!-2]
tests.converter.test_insert_punctuation_converter ‑ test_default_swap[count 1 2 3 4 5 6 7 8 9 and 10.-3]
tests.converter.test_insert_punctuation_converter ‑ test_invalid_punctuation_list[ ]
tests.converter.test_insert_punctuation_converter ‑ test_invalid_punctuation_list[//]
tests.converter.test_insert_punctuation_converter ‑ test_invalid_punctuation_list[1]
tests.converter.test_insert_punctuation_converter ‑ test_invalid_punctuation_list[a]
tests.converter.test_insert_punctuation_converter ‑ test_invalid_punctuation_list[~~]
tests.converter.test_insert_punctuation_converter ‑ test_invalid_word_swap_ratio[-0.1]
tests.converter.test_insert_punctuation_converter ‑ test_invalid_word_swap_ratio[1.5]
tests.converter.test_insert_punctuation_converter ‑ test_word_swap_ratio[   Hello,   world!   -True-punctuation_list2-0.3-3]
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants