Merged
Conversation
Uses ua-parser/uap-rust#3 Fixes ua-parser#166
Closed
Contributor
Author
|
Forgot to put it in the commit message, but the regex-based parser is generally a bit faster than re2 (it loses by a hair on pgts, but is 80% faster on ua, and 30% on devices): The main draw is that it is compatible with pypy and graal (even though it's a cpyext) and they have excruciating pure python performances on uap tests, here's pypy: So not only does it give these "native" performances, it's an even bigger gain than the re2 parser for cpython. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the pyo3-based ua-parser/uap-rust#3
Fixes #166