Rebase to v147

[uazo]

Description

Rebase to v147

All submissions

• there are no other open Pull Requests for the same update/change
• Cromite can be built with these changes
• I have tested that the new change works as intended (AVD or physical device will do)

Format

• patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
• patch description contains explanation of changes
• no unnecessary whitespace or unrelated changes

[PF4Public]

:)

ERROR at //chrome/test/BUILD.gn:6960:7: Undefined identifier
  if (enable_chrome_notifications) {
      ^--------------------------
See //BUILD.gn:154:11: which caused the file to be included.
          "//chrome/test:browser_tests",
          ^----------------------------

[theimpulson]

Hi,

Unsure if this is needed or maybe another patch/argument resolves this but after applying bromite-build-utils.patch and Add-cromite-flags-support.patch patches, the build broke for me and required to do the following changes. Am I missing something?

---
 components/components_strings.grd.gritdeps      | 1 +
 components/webui/flags/resources/experiment.css | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/components/components_strings.grd.gritdeps b/components/components_strings.grd.gritdeps
--- a/components/components_strings.grd.gritdeps
+++ b/components/components_strings.grd.gritdeps
@@ -14,6 +14,7 @@ components/components_settings_strings.grdp
 components/compose_strings.grdp
 components/contextual_tasks_strings.grdp
 components/crash_strings.grdp
+components/cromite_components_strings_grd/placeholder.txt
 components/dialog_strings.grdp
 components/dom_distiller_strings.grdp
 components/enterprise_strings.grdp
diff --git a/components/webui/flags/resources/experiment.css b/components/webui/flags/resources/experiment.css
--- a/components/webui/flags/resources/experiment.css
+++ b/components/webui/flags/resources/experiment.css
@@ -86,7 +86,7 @@
 }
 
 .experiment-on select {
-  background: #dddddd;
+  background: #ddd;
   color: var(--link-color);
 }
 
-- 

[uazo]

You should only use it once I've finished: it’s normal for the first build not to compile.
When rebasing, I always carry out a two-step process: first, I use wiggle (via tools/apply-all-patch.sh) without building, to ensure I don’t lose any changes from the previous version. At this stage, I don’t have the build container available.
I then initiate the creation of the Docker container and, once the compiler is available, I sort out and adapt the remaining changes.

[PF4Public]

@uazo Is it of any use to you if we report build failures here? It is clear that you will eventually find them and fix them, but still.

[uazo]

No, I don’t need any more build errors until I’m finished.
I’d already seen the ones you mentioned, and believe me, they weren’t the only ones, but these changes 6465669 were necessary