Skip to content

implement get() with timeout #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kira1009 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

implement get() with timeout #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tchannel-core/src/main/java/com/uber/tchannel/api/TFuture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Executor;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import java.util.concurrent.atomic.AtomicInteger;

/**
Expand Down Expand Up @@ -162,8 +163,9 @@
}

@Override
public V get(long timeout, TimeUnit unit) {
throw new UnsupportedOperationException("Get timeout is unsupported. Use request timeout instead.");
public V get(long timeout, TimeUnit unit) throws InterruptedException, ExecutionException, TimeoutException {
listenerCount.incrementAndGet();
return super.get(timeout, unit);

Check warning on line 168 in tchannel-core/src/main/java/com/uber/tchannel/api/TFuture.java

View check run for this annotation

Codecov / codecov/patch

tchannel-core/src/main/java/com/uber/tchannel/api/TFuture.java#L167-L168 

Added lines #L167 - L168 were not covered by tests
}

@Override
Expand Down