Chore/add build for jupyterlab generic #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfshao
reviewed
Dec 9, 2025
| # Symlink data directory mounted at root | ||
| ln -s /data . | ||
| # # Symlink data directory mounted at root | ||
| # ln -s /data . |
Contributor
There was a problem hiding this comment.
I think we should remove this, since this is already being done by hatchery
those config file symlinks could stay commented above, since we still need to figure out exactly how could we address them
Contributor
Author
There was a problem hiding this comment.
I've removed these 2 commented lines for /data and left the other comments in place. Is that correct?
mfshao
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: HP-2406
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes