Skip to content

Manifest button and object_id edits #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
qbatcheller wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Manifest button and object_id edits #994

qbatcheller wants to merge 12 commits into from

Conversation

@qbatcheller
Copy link
Contributor

@qbatcheller qbatcheller commented Dec 11, 2025

Adding a "download manifest" button to the page as well as adding "object_id" to the radiology report explorer.

Link to Jira ticket if there is one:
https://ctds-planx.atlassian.net/browse/MIDRC-1182

@qbatcheller
Manifest button and object_id edits
acdeb7d 
Adding a "download manifest" button to the page as well as adding "object_id" to the radiology report explorer.
cgmeyer
cgmeyer requested changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@cgmeyer cgmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe under the "guppyConfig" section of the Radiology Reports tab explorer config, we need a "manifestMapping" section for this download-manifest button to work. I'm not totally sure on the format here, but something like this might work? I will ask a dev to review:

            "manifestMapping": {
                "resourceIndexType": "radiology_report",
                "resourceIdField": "object_id",
                "referenceIdFieldInResourceIndex": "_radiology_report_id",
                "referenceIdFieldInDataIndex": "_radiology_report_id",
                "useFilterForCounts": false
            },

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 0 15 15
tests/test_gen3_workflow.py 0 0 11 11
tests/test_pfb_export.py 0 0 1 1
tests/test_data_upload.py 6 0 3 9
tests/test_audit_service.py 3 0 3 6
tests/test_ras_authn.py 0 0 3 3
tests/test_graph_submit_and_query.py 13 0 1 14
tests/test_dbgap.py 4 0 1 5
tests/test_study_viewer.py 0 0 3 3
tests/test_user_data_library.py 0 0 3 3
tests/test_discoverypage.py 0 0 1 1
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_aggregate_mds.py 0 0 1 1
tests/test_google_data_access.py 0 0 1 1
tests/test_env_sanity.py 0 0 1 1
tests/test_register_user.py 0 0 2 2
tests/test_manifest_service.py 0 0 1 1
tests/test_dicom_viewer.py 4 0 0 4
tests/test_centralized_auth.py 15 1 0 16
tests/test_guppy_service.py 8 0 0 8
tests/test_presigned_url.py 7 0 0 7
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_token.py 5 0 0 5
tests/test_requestor.py 5 0 0 5
tests/test_workspace.py 1 0 0 1
tests/test_oidc_client.py 2 0 0 2
tests/test_login_page.py 2 0 0 2
tests/test_homepage.py 1 0 0 1
tests/test_client_credentials.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
tests/test_etl.py 1 0 0 1
TOTAL 83 1 53 137

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 0 15 15
tests/test_gen3_workflow.py 0 0 11 11
tests/test_pfb_export.py 0 0 1 1
tests/test_data_upload.py 6 0 3 9
tests/test_audit_service.py 3 0 3 6
tests/test_ras_authn.py 0 0 3 3
tests/test_graph_submit_and_query.py 13 0 1 14
tests/test_dbgap.py 4 0 1 5
tests/test_study_viewer.py 0 0 3 3
tests/test_user_data_library.py 0 0 3 3
tests/test_discoverypage.py 0 0 1 1
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_aggregate_mds.py 0 0 1 1
tests/test_google_data_access.py 0 0 1 1
tests/test_env_sanity.py 0 0 1 1
tests/test_register_user.py 0 0 2 2
tests/test_manifest_service.py 0 0 1 1
tests/test_dicom_viewer.py 4 0 0 4
tests/test_centralized_auth.py 15 1 0 16
tests/test_guppy_service.py 8 0 0 8
tests/test_presigned_url.py 7 0 0 7
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_token.py 5 0 0 5
tests/test_requestor.py 5 0 0 5
tests/test_workspace.py 1 0 0 1
tests/test_oidc_client.py 2 0 0 2
tests/test_login_page.py 2 0 0 2
tests/test_homepage.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
tests/test_client_credentials.py 1 0 0 1
tests/test_etl.py 1 0 0 1
TOTAL 83 1 53 137

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 0 15 15
tests/test_gen3_workflow.py 0 0 11 11
tests/test_pfb_export.py 0 0 1 1
tests/test_data_upload.py 6 0 3 9
tests/test_audit_service.py 3 0 3 6
tests/test_ras_authn.py 0 0 3 3
tests/test_graph_submit_and_query.py 13 0 1 14
tests/test_dbgap.py 4 0 1 5
tests/test_study_viewer.py 0 0 3 3
tests/test_user_data_library.py 0 0 3 3
tests/test_discoverypage.py 0 0 1 1
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_aggregate_mds.py 0 0 1 1
tests/test_google_data_access.py 0 0 1 1
tests/test_env_sanity.py 0 0 1 1
tests/test_register_user.py 0 0 2 2
tests/test_manifest_service.py 0 0 1 1
tests/test_dicom_viewer.py 4 0 0 4
tests/test_centralized_auth.py 15 1 0 16
tests/test_guppy_service.py 8 0 0 8
tests/test_presigned_url.py 7 0 0 7
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_token.py 5 0 0 5
tests/test_requestor.py 5 0 0 5
tests/test_workspace.py 1 0 0 1
tests/test_oidc_client.py 2 0 0 2
tests/test_login_page.py 2 0 0 2
tests/test_homepage.py 1 0 0 1
tests/test_client_credentials.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
tests/test_etl.py 1 0 0 1
TOTAL 83 1 53 137

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 0 15 15
tests/test_gen3_workflow.py 0 0 11 11
tests/test_audit_service.py 3 0 3 6
tests/test_ras_authn.py 0 0 3 3
tests/test_study_viewer.py 0 0 3 3
tests/test_register_user.py 0 0 2 2
tests/test_presigned_url.py 7 0 0 7
tests/test_requestor.py 5 0 0 5
tests/test_login_page.py 1 1 0 2
TOTAL 16 1 37 54

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

filepath passed skipped SUBTOTAL
tests/test_oauth2.py 0 15 15
tests/test_pfb_export.py 0 1 1
tests/test_data_upload.py 6 3 9
tests/test_audit_service.py 3 3 6
tests/test_ras_authn.py 0 3 3
tests/test_graph_submit_and_query.py 13 1 14
tests/test_dbgap.py 4 1 5
tests/test_study_viewer.py 0 3 3
tests/test_user_data_library.py 0 3 3
tests/test_discoverypage.py 0 1 1
tests/test_gen3ff_landing_page.py 0 2 2
tests/test_aggregate_mds.py 0 1 1
tests/test_google_data_access.py 0 1 1
tests/test_manifest_service.py 0 1 1
tests/test_env_sanity.py 0 1 1
tests/test_register_user.py 0 2 2
tests/test_dicom_viewer.py 4 0 4
tests/test_centralized_auth.py 16 0 16
tests/test_guppy_service.py 8 0 8
tests/test_presigned_url.py 7 0 7
tests/test_requestor.py 5 0 5
tests/test_drs_endpoint.py 4 0 4
tests/test_user_token.py 5 0 5
tests/test_workspace.py 1 0 1
tests/test_oidc_client.py 2 0 2
tests/test_login_page.py 2 0 2
tests/test_homepage.py 1 0 1
tests/test_client_credentials.py 1 0 1
tests/test_etl.py 1 0 1
tests/test_gen3client.py 1 0 1
TOTAL 84 42 126

Please find the detailed integration test report here

Please find the Github Action logs here

cgmeyer
cgmeyer previously approved these changes Dec 19, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 19, 2025

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 0 15 15
tests/test_gen3_workflow.py 0 0 11 11
tests/test_pfb_export.py 0 0 1 1
tests/test_data_upload.py 6 0 3 9
tests/test_audit_service.py 3 0 3 6
tests/test_ras_authn.py 0 0 3 3
tests/test_graph_submit_and_query.py 13 0 1 14
tests/test_dbgap.py 4 0 1 5
tests/test_user_data_library.py 0 0 3 3
tests/test_discoverypage.py 0 0 1 1
tests/test_study_viewer.py 0 0 3 3
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_aggregate_mds.py 0 0 1 1
tests/test_google_data_access.py 0 0 1 1
tests/test_env_sanity.py 0 0 1 1
tests/test_register_user.py 0 0 2 2
tests/test_manifest_service.py 0 0 1 1
tests/test_dicom_viewer.py 4 0 0 4
tests/test_guppy_service.py 8 0 0 8
tests/test_presigned_url.py 7 0 0 7
tests/test_requestor.py 5 0 0 5
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_token.py 5 0 0 5
tests/test_centralized_auth.py 9 7 0 16
tests/test_workspace.py 1 0 0 1
tests/test_oidc_client.py 2 0 0 2
tests/test_login_page.py 2 0 0 2
tests/test_homepage.py 1 0 0 1
tests/test_client_credentials.py 1 0 0 1
tests/test_etl.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
TOTAL 77 7 53 137

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 0 15 15
tests/test_gen3_workflow.py 0 0 11 11
tests/test_pfb_export.py 0 0 1 1
tests/test_data_upload.py 6 0 3 9
tests/test_audit_service.py 3 0 3 6
tests/test_ras_authn.py 0 0 3 3
tests/test_graph_submit_and_query.py 13 0 1 14
tests/test_dbgap.py 4 0 1 5
tests/test_study_viewer.py 0 0 3 3
tests/test_user_data_library.py 0 0 3 3
tests/test_discoverypage.py 0 0 1 1
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_register_user.py 0 0 2 2
tests/test_aggregate_mds.py 0 0 1 1
tests/test_google_data_access.py 0 0 1 1
tests/test_env_sanity.py 0 0 1 1
tests/test_manifest_service.py 0 0 1 1
tests/test_dicom_viewer.py 4 0 0 4
tests/test_guppy_service.py 8 0 0 8
tests/test_presigned_url.py 7 0 0 7
tests/test_requestor.py 5 0 0 5
tests/test_drs_endpoint.py 4 0 0 4
tests/test_centralized_auth.py 9 7 0 16
tests/test_user_token.py 5 0 0 5
tests/test_workspace.py 1 0 0 1
tests/test_oidc_client.py 2 0 0 2
tests/test_client_credentials.py 1 0 0 1
tests/test_login_page.py 2 0 0 2
tests/test_etl.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
tests/test_homepage.py 1 0 0 1
TOTAL 77 7 53 137

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 0 15 15
tests/test_gen3_workflow.py 0 0 11 11
tests/test_pfb_export.py 0 0 1 1
tests/test_data_upload.py 6 0 3 9
tests/test_audit_service.py 3 0 3 6
tests/test_ras_authn.py 0 0 3 3
tests/test_graph_submit_and_query.py 13 0 1 14
tests/test_dbgap.py 4 0 1 5
tests/test_study_viewer.py 0 0 3 3
tests/test_user_data_library.py 0 0 3 3
tests/test_discoverypage.py 0 0 1 1
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_aggregate_mds.py 0 0 1 1
tests/test_google_data_access.py 0 0 1 1
tests/test_env_sanity.py 0 0 1 1
tests/test_register_user.py 0 0 2 2
tests/test_manifest_service.py 0 0 1 1
tests/test_dicom_viewer.py 4 0 0 4
tests/test_guppy_service.py 8 0 0 8
tests/test_presigned_url.py 7 0 0 7
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_token.py 5 0 0 5
tests/test_requestor.py 5 0 0 5
tests/test_workspace.py 1 0 0 1
tests/test_oidc_client.py 2 0 0 2
tests/test_login_page.py 2 0 0 2
tests/test_centralized_auth.py 9 7 0 16
tests/test_homepage.py 1 0 0 1
tests/test_client_credentials.py 1 0 0 1
tests/test_etl.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
TOTAL 77 7 53 137

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 0 15 15
tests/test_gen3_workflow.py 0 0 11 11
tests/test_pfb_export.py 0 0 1 1
tests/test_data_upload.py 6 0 3 9
tests/test_audit_service.py 3 0 3 6
tests/test_ras_authn.py 0 0 3 3
tests/test_graph_submit_and_query.py 13 0 1 14
tests/test_dbgap.py 4 0 1 5
tests/test_study_viewer.py 0 0 3 3
tests/test_user_data_library.py 0 0 3 3
tests/test_discoverypage.py 0 0 1 1
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_aggregate_mds.py 0 0 1 1
tests/test_google_data_access.py 0 0 1 1
tests/test_env_sanity.py 0 0 1 1
tests/test_register_user.py 0 0 2 2
tests/test_manifest_service.py 0 0 1 1
tests/test_dicom_viewer.py 4 0 0 4
tests/test_guppy_service.py 8 0 0 8
tests/test_presigned_url.py 7 0 0 7
tests/test_drs_endpoint.py 4 0 0 4
tests/test_user_token.py 5 0 0 5
tests/test_requestor.py 5 0 0 5
tests/test_workspace.py 1 0 0 1
tests/test_oidc_client.py 2 0 0 2
tests/test_centralized_auth.py 9 7 0 16
tests/test_login_page.py 2 0 0 2
tests/test_homepage.py 1 0 0 1
tests/test_client_credentials.py 1 0 0 1
tests/test_etl.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
TOTAL 77 7 53 137

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 0 0 15 15
tests/test_gen3_workflow.py 0 0 11 11
tests/test_pfb_export.py 0 0 1 1
tests/test_data_upload.py 5 1 3 9
tests/test_audit_service.py 3 0 3 6
tests/test_ras_authn.py 0 0 3 3
tests/test_graph_submit_and_query.py 13 0 1 14
tests/test_dbgap.py 4 0 1 5
tests/test_study_viewer.py 0 0 3 3
tests/test_user_data_library.py 0 0 3 3
tests/test_discoverypage.py 0 0 1 1
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_aggregate_mds.py 0 0 1 1
tests/test_google_data_access.py 0 0 1 1
tests/test_env_sanity.py 0 0 1 1
tests/test_register_user.py 0 0 2 2
tests/test_manifest_service.py 0 0 1 1
tests/test_dicom_viewer.py 4 0 0 4
tests/test_guppy_service.py 8 0 0 8
tests/test_presigned_url.py 7 0 0 7
tests/test_requestor.py 5 0 0 5
tests/test_drs_endpoint.py 4 0 0 4
tests/test_centralized_auth.py 9 7 0 16
tests/test_user_token.py 5 0 0 5
tests/test_workspace.py 1 0 0 1
tests/test_oidc_client.py 2 0 0 2
tests/test_login_page.py 2 0 0 2
tests/test_homepage.py 1 0 0 1
tests/test_client_credentials.py 1 0 0 1
tests/test_etl.py 1 0 0 1
tests/test_gen3client.py 1 0 0 1
TOTAL 76 8 53 137

Please find the detailed integration test report here

Please find the Github Action logs here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgmeyer cgmeyer cgmeyer approved these changes

@AJuehne-CTDS AJuehne-CTDS Awaiting requested review from AJuehne-CTDS AJuehne-CTDS is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qbatcheller @cgmeyer