Conversation
|
Creating a draft PR so I can note the changes I made to your version in case it causes confusion.
|
2e00881 to
8041794
Compare
|
The force push is to remove a merge commit that committed unrelated files |
…Visualization into danknight-scalebar
|
@dan-knight I'd recommend running a few fuzz tests to evaluate the robustness of the scalebars with varying axis values. I tested with two edges using different scales, but it would be helpful to test on scales that differ by a few orders of magnitude. |
dan-knight
left a comment
There was a problem hiding this comment.
Looks good! The separate viewport approach is ideal in my opinion. We may even want to refactor some other code to use this in future. Anyway, looks great. Most common value is a good default. We can even add the option to specify the scalebar style in future.
Have we thought about what might happen if someone wants one y-axis and one scalebar? Am I right that this code would support that as written?
It wont support that because the current |

Description
Add scalebar option to tree plots
Closes #144
Checklist
This PR does NOT contain Protected Health Information (PHI). A repo may need to be deleted if such data is uploaded.
Disclosing PHI is a major problem1 - Even a small leak can be costly2.
This PR does NOT contain germline genetic data3, RNA-Seq, DNA methylation, microbiome or other molecular data4.
.png, .jpeg),.pdf,.RData,.xlsx,.doc,.ppt, or other output files.To automatically exclude such files using a .gitignore file, see here for example.
I have read the code review guidelines and the code review best practice on GitHub check-list.
I have set up or verified the
mainbranch protection rule following the github standards before opening this pull request.The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have added the major changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.Footnotes
UCLA Health reaches $7.5m settlement over 2015 breach of 4.5m patient records ↩
The average healthcare data breach costs $2.2 million, despite the majority of breaches releasing fewer than 500 records. ↩
Genetic information is considered PHI.
Forensic assays can identify patients with as few as 21 SNPs ↩
RNA-Seq, DNA methylation, microbiome, or other molecular data can be used to predict genotypes (PHI) and reveal a patient's identity. ↩