Skip to content

(Frontend) Remove unnecessary return + change let to const + remove whitespace#154

Merged
SudKul merged 1 commit intoudacity:masterfrom
AlbertVilaCalvo:remove-unnecessary-return
Jan 5, 2022
Merged

(Frontend) Remove unnecessary return + change let to const + remove whitespace#154
SudKul merged 1 commit intoudacity:masterfrom
AlbertVilaCalvo:remove-unnecessary-return

Conversation

@AlbertVilaCalvo
Copy link
Copy Markdown
Contributor

A bit of code cleaning. I fixed the warnings I got on WebStorm.

I've verified that the frontend app still works fine, with the completed backend code of the project.

@AlbertVilaCalvo AlbertVilaCalvo requested a review from a team as a code owner December 30, 2021 19:34
@AlbertVilaCalvo AlbertVilaCalvo requested review from SudKul and removed request for a team December 30, 2021 19:34
@SudKul
Copy link
Copy Markdown
Contributor

SudKul commented Jan 5, 2022

Hi @AlbertVilaCalvo
I am gonna accept these changes. Thanks 👍🏼
For records: You have removed return because functions are not returning anything explicitly, and have changed let to const to avoid any accidental reassignment.

@SudKul SudKul merged commit 86ad95a into udacity:master Jan 5, 2022
@AlbertVilaCalvo AlbertVilaCalvo deleted the remove-unnecessary-return branch January 5, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants