Skip to content

Fix for broken form on 'create artist' page#54

Closed
nickever wants to merge 1 commit intoudacity:masterfrom
nickever:patch-2
Closed

Fix for broken form on 'create artist' page#54
nickever wants to merge 1 commit intoudacity:masterfrom
nickever:patch-2

Conversation

@nickever
Copy link
Copy Markdown

Removed 'id=form.state' attribute to fix broken display of genre and facebook link form
Corrected error in 'for' attribute for facebook label.

Removed 'id=form.state' attribute to fix broken display of genre and facebook link form
Corrected error in 'for' attribute for facebook label.
@nickever
Copy link
Copy Markdown
Author

This same fix is also required for new_venues.html

@dolugen
Copy link
Copy Markdown

dolugen commented May 18, 2020

You beat me to it 👍

@mohannadize
Copy link
Copy Markdown

The file projects/01_fyyur/starter_code/templates/forms/new_venue.html has the same issue.

@bc-maia
Copy link
Copy Markdown

bc-maia commented Oct 11, 2020

hello! have found this problem and after sometime this fix, it worked for me too, but it should already be merged so new students wouldn't lose time looking for some problem which's not original from their code.

@SudKul
Copy link
Copy Markdown
Contributor

SudKul commented Mar 16, 2021

Hi @nickever
Thanks for suggesting the update to the starter code. Your proposed updates have already been merged in #117
We appreciate your contribution.

@SudKul SudKul closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants