Skip to content

Address review feedback in uninstall JSON, guarded execution, and context provenance#24

Merged
fqjony merged 3 commits into
fix/release-0.10.0from
copilot/handle-bots-feedback
May 13, 2026
Merged

Address review feedback in uninstall JSON, guarded execution, and context provenance#24
fqjony merged 3 commits into
fix/release-0.10.0from
copilot/handle-bots-feedback

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

This follow-up addresses the actionable bot feedback on the release PR. The changes tighten machine-readable failure reporting, make guarded timeouts clean up spawned processes correctly, and remove generated dev.kit artifacts from manifest provenance.

  • Uninstall JSON contract

    • capture bin/scripts/uninstall.sh exit status in JSON mode
    • return ok: false with an error field on failure instead of always reporting success
    • preserve binary_removed / home_removed from actual post-run state
  • Guarded timeout behavior

    • terminate descendant processes, not just the top-level PID, when a guarded command exceeds the hard timeout
    • escalate from TERM to KILL after a short grace period
    • keep timeout handling bounded even when the command spawns background work
  • Repo context provenance

    • exclude generated .rabbit/dev.kit/* artifacts from contract-evidence scanning
    • regenerate .rabbit/context.yaml so used_by / evidence only reflect repo-owned sources
  • Repo write error reporting

    • distinguish timeout failures (124) from other context write failures
    • surface the actual non-timeout exit status instead of reporting every failure as a timeout
  • Suite portability and coverage

    • replace the Perl-based context mutation in /home/runner/work/dev.kit/dev.kit/tests/suite.sh with a portable shell/awk helper
    • add coverage for uninstall failure JSON, timeout child cleanup, non-timeout repo write failures, and generated .rabbit/dev.kit/* exclusion
# before
dev.kit --json uninstall --yes
# => { "command": "uninstall", "ok": true, ... }  # even if uninstall failed

# after
dev.kit --json uninstall --yes
# => { "command": "uninstall", "ok": false, "error": "...", ... }

Copilot AI and others added 3 commits May 13, 2026 00:41
Agent-Logs-Url: https://github.com/udx/dev.kit/sessions/62e2aa86-06f2-460f-b73b-bbd393fc0e57

Co-authored-by: fqjony <12067297+fqjony@users.noreply.github.com>
Agent-Logs-Url: https://github.com/udx/dev.kit/sessions/62e2aa86-06f2-460f-b73b-bbd393fc0e57

Co-authored-by: fqjony <12067297+fqjony@users.noreply.github.com>
Agent-Logs-Url: https://github.com/udx/dev.kit/sessions/b8123faf-8ff0-4d27-bfae-714f16e2046d

Co-authored-by: fqjony <12067297+fqjony@users.noreply.github.com>
@fqjony fqjony marked this pull request as ready for review May 13, 2026 01:02
@fqjony fqjony merged commit a7e8ac7 into fix/release-0.10.0 May 13, 2026
@fqjony fqjony deleted the copilot/handle-bots-feedback branch May 13, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants