This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Conversation
Add `parse_as_generator` method to MeCabTagger, JanomeTagger and Tagger(base) to save CPU and memory resources. For now, `tagger.parse()` is called automatically in `core.chat()` so this new method is unused. TODO: Enable to switch parsing morph automatically or manually
Enable to switch off parsing morph by passing `parse_morph=False` when create Minette object. Also add `tagger` to DialogService and DialogRouter. To parse manually call `self.tagger.parse(request.text)` or `self.tagger.parse_as_generator(request.text)`.
This reverts commit 2ea3663.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
parse_as_generatormethod to MeCabTagger, JanomeTagger and Tagger(base) to save CPU and memory resources.For now,
tagger.parse()is called automatically incore.chat()so this new method is unused.TODO: Enable to switch parsing morph automatically or manually. The way for app code to access tagger should be well considered.