Skip to content

fix not decoding encoded path and search params when synchronising the state with the current url.#618

Merged
christopherthielen merged 10 commits intomasterfrom
bugfix/340-encoded-params
Jul 17, 2020
Merged

fix not decoding encoded path and search params when synchronising the state with the current url.#618
christopherthielen merged 10 commits intomasterfrom
bugfix/340-encoded-params

Conversation

@wawyed
Copy link
Copy Markdown
Member

@wawyed wawyed commented Jun 18, 2020 •
edited
Loading

@wawyed
Copy link
Copy Markdown
Member Author

wawyed commented Jun 18, 2020

On the getDetails method inside urlMatcher.ts. We use encodeURIComponent if the parameter is not raw. We need to use decodeURIComponent to decode it when we parse the browser url for parameters.

christopherthielen
christopherthielen reviewed Jul 3, 2020
View reviewed changes
Comment thread src/url/interface.ts
@christopherthielen christopherthielen merged commit 89e99cd into master Jul 17, 2020
@christopherthielen christopherthielen deleted the bugfix/340-encoded-params branch July 17, 2020 16:42
@christopherthielen christopherthielen mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherthielen christopherthielen christopherthielen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

broken path/query params

2 participants

@wawyed @christopherthielen