vdalw and fvdump

[jonmaddock]

In GitLab by @jmorris-uk on Feb 7, 2018, 13:57

Is there a reason why both vdalw and fvdump are iteration variables. Having looked at Git blame it appears they were both added 63 months ago by pknight.

Normally for a constraint equation only fvdump would be an iteration variable and vdalw would be a user input? Should we remove vdalw as an iteration variable?

@mkovari @rkemp @Hlux

[jonmaddock]

In GitLab by @mkovari on Feb 7, 2018, 14:00

Should we remove vdalw as an iteration variable?
Yes.

[jonmaddock]

In GitLab by @rkemp on Feb 7, 2018, 14:35

I think so. In an admittedly cursory glance, I couldn’t see anywhere it was actually used except in the constraint equation, and that’s what the f-value is for.

[jonmaddock]

In GitLab by @mkovari on Feb 14, 2018, 14:42

The problem is that vdalw is used as an iteration variable in several parts of the test suite. Moreover, the upper bound varies from file to file, and the actual final value of vdalw is sometimes not equal to its upper bound.

I suggest we tackle this in stages.

• Make sure that vdalw is not used as an iteration variable in any current baseline runs.
• When tidying up the test suite, remove all occurences of vdalw as an iteration variable.
• Remove the option from the code.

vdalw /20.0/ : max voltage across TF coil during quench (kV) (iteration variable 52)