Get examples.ipynb working#2941
Merged
jonmaddock merged 4 commits intomainfrom Sep 26, 2023
Merged
Conversation
060da6a to
1375fe7
Compare
jonmaddock
requested changes
Sep 14, 2023
Contributor
jonmaddock
left a comment
There was a problem hiding this comment.
Just an assertion addition to the CSV test please!
jonmaddock
requested changes
Sep 15, 2023
jonmaddock
requested changes
Sep 18, 2023
provide new input file and add test for csv_output.py to check all values are positive floats
9b1476d to
8fbb4d2
Compare
jonmaddock
approved these changes
Sep 26, 2023
Contributor
jonmaddock
left a comment
There was a problem hiding this comment.
Looks great Clair. A couple of the asserts in the CSV test could be made a bit more concise, but I'm more than happy with everything else in this PR, so I'll merge it. Great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed problems within
examplesfolder. The original input file thatexamples.ipynbwas trying to use did not exist, so gave it a new input file. Thescan.ipynbfile did not have an input file so one was added. Thecsv_output.ipynbfile also did not have an input file, so added one and also changed the list of variables that would be added from the input file to the created csv file. Also added a test forcsv_output.pywhich tests that a csv file is created and that the values read in from the input file are all positive floats.Checklist
I confirm that I have completed the following checks: