Skip to content

add blender image file and add it to README#2946

Merged
jonmaddock merged 1 commit intomainfrom
2922-add-blender-images-to-readme
Oct 16, 2023
Merged

add blender image file and add it to README#2946
jonmaddock merged 1 commit intomainfrom
2922-add-blender-images-to-readme

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Sep 15, 2023

Description

Added blender generated image of reactor to the README

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould requested a review from jonmaddock September 15, 2023 13:52
@clmould clmould linked an issue Sep 15, 2023 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start Clair: this is just what we wanted. Could you check with Oli that these are the best images we have at the moment, and if there are any other views we should include (i.e. the side-by-side Process and Bluemira design view). If not, then I'm happy with this!

Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: could this go into images instead or blenderimages? We might well have more non-blender images in future.

@clmould clmould force-pushed the 2922-add-blender-images-to-readme branch from abedd5d to 23fae51 Compare October 13, 2023 11:26
@clmould clmould changed the title add blender image file and add it to read.me add blender image file and add it to README Oct 13, 2023
@clmould clmould requested a review from jonmaddock October 13, 2023 11:43
Comment thread README.md
Comment thread README.md
@jonmaddock jonmaddock merged commit b7cd232 into main Oct 16, 2023
@jonmaddock jonmaddock deleted the 2922-add-blender-images-to-readme branch October 16, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Blender images to README

2 participants