Allow numpy>=1.23#2954
Closed
je-cook wants to merge 1 commit intoukaea:mainfrom
Closed
Conversation
je-cook
force-pushed
the
bump_numpy_version
branch
from
3ca4e64 to
e88ad54
Compare
timothy-nunn
reviewed
Oct 4, 2023
Collaborator
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
Building PROCESS with numpy 1.23,1.25 is fine and passes the tests. However I get a failure with numpy 1.24pi (on Mac). I have also found an issue with the SciPy version (nothing to do with this change). So I need to make a PR to fix the above issues and will transfer this change across to there
Collaborator
|
See #2963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Numpy 1.22 had some undesired behavour. In the release notes it seems to have been fixed as f2py is now deterministic (!) see: https://github.com/numpy/numpy/releases/tag/v1.23.0
There are further fixes to f2py on newer releases if this bump still has the original bug
Checklist
I confirm that I have completed the following checks: