Flush convergence callback#2956
Merged
timothy-nunn merged 1 commit intoukaea:mainfrom Oct 4, 2023
Merged
Conversation
timothy-nunn
approved these changes
Oct 4, 2023
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Cheers James, do we have any idea why this was happening? Was it when PROCESS was being run as a subprocess?
Collaborator
Author
I was running in a subprocess yeah. It sometimes happens if stdout is redirected in some way. Seen it happen on our side too previously when we weren't running a subprocess (in another context not with PROCESS). |
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The implemented convergence callback for pyvmcon doesnt flush the print statement therefore in some situations the printing won't appear on stdout until a while later.
This enforces flushing after every update.
I have no idea how you would test this so I haven't.
Checklist
I confirm that I have completed the following checks: