updated error message for obsolete vars#2973
Merged
jonmaddock merged 1 commit intomainfrom Oct 31, 2023
Merged
Conversation
jonmaddock
requested changes
Oct 16, 2023
jonmaddock
requested changes
Oct 31, 2023
Contributor
jonmaddock
left a comment
There was a problem hiding this comment.
Looks great Clair! Can you just rebase (fixup) these two commits to reduce the churn (doing and undoing) into a single commit?
b1deb0f to
bfd8ce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added to the error message for obsolete variables in the input file to state what their new variable name is from
obsolete_vars.pyas previously this was not output.Checklist
I confirm that I have completed the following checks: