Skip to content

updated error message for obsolete vars#2973

Merged
jonmaddock merged 1 commit intomainfrom
461-unknown-variable-in-input-file-obsolete-variable-in-input-file
Oct 31, 2023
Merged

updated error message for obsolete vars#2973
jonmaddock merged 1 commit intomainfrom
461-unknown-variable-in-input-file-obsolete-variable-in-input-file

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Oct 12, 2023

Description

Added to the error message for obsolete variables in the input file to state what their new variable name is from obsolete_vars.py as previously this was not output.

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Oct 12, 2023 that may be closed by this pull request
@clmould clmould requested a review from jonmaddock October 12, 2023 16:06
Comment thread process/main.py Outdated
@clmould clmould requested a review from jonmaddock October 18, 2023 16:03
Copy link
Copy Markdown
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Clair! Can you just rebase (fixup) these two commits to reduce the churn (doing and undoing) into a single commit?

@clmould clmould force-pushed the 461-unknown-variable-in-input-file-obsolete-variable-in-input-file branch from b1deb0f to bfd8ce1 Compare October 31, 2023 14:42
@clmould clmould requested a review from jonmaddock October 31, 2023 14:44
Copy link
Copy Markdown
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jonmaddock jonmaddock merged commit 7b79860 into main Oct 31, 2023
@jonmaddock jonmaddock deleted the 461-unknown-variable-in-input-file-obsolete-variable-in-input-file branch October 31, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unknown variable in input file/ obsolete variable in input file

2 participants