Skip to content

Add option to provide PROCESS solver by external package#2976

Merged
jonmaddock merged 1 commit intomainfrom
allow-external-solvers
Oct 31, 2023
Merged

Add option to provide PROCESS solver by external package#2976
jonmaddock merged 1 commit intomainfrom
allow-external-solvers

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn commented Oct 19, 2023

Description

Allows PROCESS' --solver option to try and import the solver from a package iff the provided string is not an inbuilt PROCESS solver. The string must be a valid (sub)package that provides a __process_solver__ attributes which points to a class that subclasses _Solver.

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

Copy link
Copy Markdown
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic Tim, great solution. Can you get some documentation sorted for this too (when you let the group know)?

@jonmaddock jonmaddock merged commit 32525c9 into main Oct 31, 2023
@jonmaddock jonmaddock deleted the allow-external-solvers branch October 31, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants