Add option to provide PROCESS solver by external package#2976
Merged
jonmaddock merged 1 commit intomainfrom Oct 31, 2023
Merged
Add option to provide PROCESS solver by external package#2976jonmaddock merged 1 commit intomainfrom
jonmaddock merged 1 commit intomainfrom
Conversation
jonmaddock
approved these changes
Oct 31, 2023
Contributor
jonmaddock
left a comment
There was a problem hiding this comment.
Fantastic Tim, great solution. Can you get some documentation sorted for this too (when you let the group know)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows PROCESS'
--solveroption to try and import the solver from a package iff the provided string is not an inbuilt PROCESS solver. The string must be a valid (sub)package that provides a__process_solver__attributes which points to a class that subclasses_Solver.Checklist
I confirm that I have completed the following checks: