Rearchitect and jit CS fatigue#2984
Merged
timothy-nunn merged 3 commits intoukaea:mainfrom Nov 3, 2023
Merged
Conversation
Speeds up my convergence by x10 🤯
Collaborator
Author
|
from my side is there any reason to write |
timothy-nunn
approved these changes
Nov 3, 2023
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Rearchitect and jit CS fatigue Speeds up my convergence by x10 🤯 * black format * Update cs_fatigue.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have jitted and reduced recalculation of the same quantities in cs fatigue and reduced calls to np.zeros in pfcoils.
I've also reduced unneeded variable assignment (assigned and then used once) because it is a slow operation in python.
Also * is faster than /
I thought it was worth it for a routine where 50% of time was spent in my run
Speeds up my convergence by >x10 🤯 (2207 iterations -> 134 iterations)
Checklist
I confirm that I have completed the following checks: