2986 rebco critical current adjustment for type of cable#2987
Merged
timothy-nunn merged 4 commits intomainfrom Nov 3, 2023
Merged
2986 rebco critical current adjustment for type of cable#2987timothy-nunn merged 4 commits intomainfrom
timothy-nunn merged 4 commits intomainfrom
Conversation
timothy-nunn
approved these changes
Nov 3, 2023
timothy-nunn
deleted the
2986-rebco-critical-current-adjustment-for-type-of-cable
branch
chris-ashe
added a commit
that referenced
this pull request
Apr 22, 2024
* removed fudge factor * docstring update * docstring update 2 * test_hijc_rebco test corrected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A correction factor of 0.4 has been removed from the
jcritcalculation as it was implemented assuming a CORC style cable which PROCESS does not model.It has now been removed.
test_hijc_rebcounit test values adjusted.Checklist
I confirm that I have completed the following checks: