Convert physics.f90 to Python#2993
Merged
timothy-nunn merged 1 commit intomainfrom Jan 31, 2024
Merged
Conversation
e8bfb56 to
33b8d66
Compare
Collaborator
Author
|
When converting
This causes the unit test, created from values seen in |
04f422f to
aac21e2
Compare
71d05ba to
64ed103
Compare
334ae8b to
5a6e6cb
Compare
jonmaddock
reviewed
Jan 26, 2024
Contributor
jonmaddock
left a comment
There was a problem hiding this comment.
Looks great Tim, huge one! Just a couple of chopped-off descriptions in the mfile output, but otherwise fine.
d8c880a to
e125e92
Compare
jonmaddock
approved these changes
Jan 30, 2024
Contributor
|
Can't rebase due to conflicts. Can you sort these, then good to go in. |
c698cd1 to
a48f373
Compare
a48f373 to
8add79e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Converts the remaining physics.f90 module into Python
Checklist
I confirm that I have completed the following checks: