2994 new eccd current drive model to account for zeff and te with a cutoff function#2999
Merged
jonmaddock merged 12 commits intomainfrom Dec 14, 2023
Conversation
chris-ashe
requested review from
timothy-nunn
and removed request for
timothy-nunn
chris-ashe
added
Physics
timothy-nunn
requested changes
Nov 29, 2023
Collaborator
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
Couple of questions that need addressing.
Collaborator
|
Also @chris-ashe, if you have some reference values would it be possible to add in a quick test for this |
Collaborator
Author
|
Test is now covered in #3013 |
chris-ashe
force-pushed
the
2994-new-eccd-current-drive-model-to-account-for-zeff-and-te-with-a-cutoff-function
branch
from
f260d57 to
f319f5e
Compare
chris-ashe
changed the title
jonmaddock
approved these changes
Dec 14, 2023
Contributor
jonmaddock
left a comment
jonmaddock
left a comment
There was a problem hiding this comment.
Looks great after rebasing.
Contributor
|
As Tim's questions have been answered and Chris is keen to get this in, I hope you don't mind me merging this Tim! |
jonmaddock
deleted the
2994-new-eccd-current-drive-model-to-account-for-zeff-and-te-with-a-cutoff-function
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New model has been input to account for ECCD cutoff as a function of electron temperature and effective charge
effrfss&effcdplot_proc.Checklist
I confirm that I have completed the following checks: