3004 remove remnants of plasmod functionality#3005
Merged
timothy-nunn merged 15 commits intomainfrom Dec 20, 2023
Merged
Conversation
2 tasks
timothy-nunn
requested changes
Dec 7, 2023
Collaborator
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
One thing I think should be changed, another thing that can be done while your doing that.
| "no": 174, | ||
| "level": 3, | ||
| "message": "CONVERT_PLASMOD2PROCESS: PLASMOD Transport model (ipedestal=3) has not converged" | ||
| "message": "OBSOLETE" |
Collaborator
There was a problem hiding this comment.
I suspect we can actually removed these entries from the json file entirely since they should never be called, and if they were it would raise an error (probably what we want).
timothy-nunn
approved these changes
Dec 20, 2023
timothy-nunn
deleted the
3004-remove-remnants-of-plasmod-functionality
branch
chris-ashe
added a commit
that referenced
this pull request
Apr 22, 2024
* initial physics_variables * remove build routines in caller.py for ipedestal=3 * removed plasmod condition for NBI * plasmod print in output.py * plasmod remove for process.conf * run_process.conf test plasmod removed * plasmod removed from ref_dicts.json * general plasmod removal * plasmod removed from gitignore * plasmod removed from plot_proc.py * plasmod removed from errorlist.json * ipedetsal == 2 removal * remove plasmod from docs * change contact details * remove obsolete errors
chris-ashe
added a commit
that referenced
this pull request
Apr 22, 2024
* initial physics_variables * remove build routines in caller.py for ipedestal=3 * removed plasmod condition for NBI * plasmod print in output.py * plasmod remove for process.conf * run_process.conf test plasmod removed * plasmod removed from ref_dicts.json * general plasmod removal * plasmod removed from gitignore * plasmod removed from plot_proc.py * plasmod removed from errorlist.json * ipedetsal == 2 removal * remove plasmod from docs * change contact details * remove obsolete errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some bits of PLASMOD and the associated
ipedestal = 2,3options were still present these have been removed.@timothy-nunn PLASMOD is still noted in example.ipynb
Checklist
I confirm that I have completed the following checks: